chore: Use type declaration instead of type hint#7338
Merged
Wirone merged 2 commits intoPHP-CS-Fixer:masterfrom Sep 27, 2023
Merged
chore: Use type declaration instead of type hint#7338Wirone merged 2 commits intoPHP-CS-Fixer:masterfrom
Wirone merged 2 commits intoPHP-CS-Fixer:masterfrom
Conversation
6ec508f to
8089a2a
Compare
Merged
1 task
8089a2a to
b607980
Compare
1 task
Wirone
approved these changes
Sep 27, 2023
ebb171f to
063f85d
Compare
Member
|
Thanks @localheinz 🍻! |
Member
Author
|
Thank you, @Wirone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request
Somewhat related to #7330 (comment).
💁♂️ Also see https://www.php.net/manual/en/language.types.declarations.php. A lot of people keep using type hint instead of type declarations, but they are officially called type declarations, so I believe it makes sense to consistently use the official wording. Maybe we can even convince some people to use the official wording.