feat: Deprecate NewWithBracesFixer and proxy to NewWithParenthesesFixer#7331
Merged
keradus merged 2 commits intoPHP-CS-Fixer:masterfrom Sep 29, 2023
Merged
feat: Deprecate NewWithBracesFixer and proxy to NewWithParenthesesFixer#7331keradus merged 2 commits intoPHP-CS-Fixer:masterfrom
NewWithBracesFixer and proxy to NewWithParenthesesFixer#7331keradus merged 2 commits intoPHP-CS-Fixer:masterfrom
Conversation
NewWithBracesFixer and proxy to NewWithParenthesesFixerNewWithBracesFixer and proxy to NewWithParenthesesFixer
741b7c8 to
a446bd5
Compare
localheinz
commented
Sep 27, 2023
a446bd5 to
99ca440
Compare
localheinz
commented
Sep 27, 2023
99ca440 to
bd1401c
Compare
8667aa8 to
5006583
Compare
0a29654 to
59e8790
Compare
1 task
Member
|
@localheinz unfortunately we need a rebase with conflict resolution, because of deprecation messages 🙂. |
59e8790 to
a36aee8
Compare
Member
Author
|
Rebased (the other pull requests as well)! |
a36aee8 to
9a860c7
Compare
NewWithBracesFixer and proxy to NewWithParenthesesFixerNewWithBracesFixer and proxy to NewWithParenthesesFixer
keradus
reviewed
Sep 29, 2023
| * | ||
| * @covers \PhpCsFixer\Fixer\Operator\NewWithParenthesesFixer | ||
| */ | ||
| final class NewWithParenthesesFixerTest extends AbstractFixerTestCase |
Member
There was a problem hiding this comment.
potentially we could apply same idea for all deprecations about not-duplicating tests?
(not only this PR)
(not enforcing, up to you)
Member
There was a problem hiding this comment.
I've disabled auto-merge for now, re-enable it if you really don't want to wait for @localheinz' response 😉.
Member
There was a problem hiding this comment.
you asked me to not block things ;P this could be added as separated PR. i go for hols today and want to release this today.
you asked me to not block things ;P
keradus
approved these changes
Sep 29, 2023
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request
NewWithBracesFixerand proxies to theNewWithParenthesesFixerRelated to #5915 (comment).
Follows #7328 (comment).