bug: Fix array/object shape phpdoc type parse#6962
Merged
kubawerlos merged 6 commits intoPHP-CS-Fixer:masterfrom May 18, 2023
Merged
bug: Fix array/object shape phpdoc type parse#6962kubawerlos merged 6 commits intoPHP-CS-Fixer:masterfrom
kubawerlos merged 6 commits intoPHP-CS-Fixer:masterfrom
Conversation
372326a to
5e1bfbe
Compare
5e1bfbe to
8d4010a
Compare
Wirone
reviewed
May 15, 2023
ef95f94 to
cdb20e3
Compare
cdb20e3 to
c1a61dd
Compare
Wirone
approved these changes
May 18, 2023
Member
Wirone
left a comment
There was a problem hiding this comment.
Honestly I am not sure if I understand all changes in TypeExpression, but looking at test cases and applied fixes to the code base it looks like it works as it should, so 👍 from me. I won't merge it, though, I want to wait for other review as well.
kubawerlos
approved these changes
May 18, 2023
Member
|
Thank you @mvorisek 👍🏼 |
This was referenced May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
array{})[^?:\h]+\h*\??\h*:\h*/.+?:\h*, now parsed by the actual grammar)array shape key grammar: https://github.com/phpstan/phpdoc-parser/blob/1.20.4/doc/grammars/type.abnf#L70