Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PHP-CS-Fixer/PHP-CS-Fixer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.18.3
Choose a base ref
...
head repository: PHP-CS-Fixer/PHP-CS-Fixer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.18.4
Choose a head ref
  • 20 commits
  • 69 files changed
  • 6 contributors

Commits on Mar 10, 2021

  1. bumped version

    keradus committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    76af6eb View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. DX: update checkbashisms

    keradus committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    9f536ed View commit details
    Browse the repository at this point in the history
  2. minor #5545 DX: update checkbashisms (keradus)

    This PR was merged into the 2.18 branch.
    
    Discussion
    ----------
    
    DX: update checkbashisms
    
    somehow, 2.20 disappeared from https://deb.debian.org/debian/pool/main/d/devscripts/
    
    Commits
    -------
    
    9f536ed DX: update checkbashisms
    keradus committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    88e1fd1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2261d76 View commit details
    Browse the repository at this point in the history
  4. minor #5540 DX: RuleSet - convert null handling to soft-warning (kera…

    …dus)
    
    This PR was squashed before being merged into the 2.18 branch.
    
    Discussion
    ----------
    
    DX: RuleSet - convert null handling to soft-warning
    
    closes #5537
    
    Commits
    -------
    
    2261d76 DX: RuleSet - convert null handling to soft-warning
    keradus committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    c4b84e0 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Configuration menu
    Copy the full SHA
    ca36da5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ff88f6 View commit details
    Browse the repository at this point in the history
  3. bug #5550 TypeAlternationTransformer - fix for typed static propertie…

    …s (kubawerlos)
    
    This PR was squashed before being merged into the 2.18 branch.
    
    Discussion
    ----------
    
    TypeAlternationTransformer - fix for typed static properties
    
    Commits
    -------
    
    5ff88f6 TypeAlternationTransformer - fix for typed static properties
    keradus committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    d46a3ef View commit details
    Browse the repository at this point in the history
  4. bug #5552 DX: test relation between function_declaration and method_a…

    …rgument_space (keradus)
    
    This PR was merged into the 2.18 branch.
    
    Discussion
    ----------
    
    DX: test relation between function_declaration and method_argument_space
    
    found here: #4085 (comment)
    
    Commits
    -------
    
    ca36da5 DX: test relation between function_declaration and method_argument_space
    keradus committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    a1467ec View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dcf5699 View commit details
    Browse the repository at this point in the history
  6. bug #5551 ClassAttributesSeparationFixer - fix for properties with ty…

    …pe alternation (kubawerlos, keradus)
    
    This PR was squashed before being merged into the 2.18 branch.
    
    Discussion
    ----------
    
    ClassAttributesSeparationFixer - fix for properties with type alternation
    
    Commented part in test can be commented out after #5550 fix.
    
    Commits
    -------
    
    dcf5699 ClassAttributesSeparationFixer - fix for properties with type alternation
    keradus committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    cbe98ff View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    701708e View commit details
    Browse the repository at this point in the history
  8. bug #4085 Priority: AlignMultilineComment should run before every Php…

    …docFixer (dmvdbrugge)
    
    This PR was merged into the 2.18 branch.
    
    Discussion
    ----------
    
    Priority: AlignMultilineComment should run before every PhpdocFixer
    
    I made use of the graph I generated with https://github.com/dmvdbrugge/fixer-prio-graph
    
    I also found a hidden priority between LineEnding and Braces, which I had to add in this PR as well, because otherwise the `@Symfony_whitespace.test` would fail.
    
    Fixes #3879
    
    Commits
    -------
    
    701708e Priority: AlignMultilineComment should run before every PhpdocFixer
    keradus committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    fc4791c View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2021

  1. NullableTypeDeclarationForDefaultNullValueFixer - fix handling promot…

    …ed properties
    jrmajor authored and keradus committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    077eb6a View commit details
    Browse the repository at this point in the history
  2. bug #5548 NullableTypeDeclarationForDefaultNullValueFixer - fix handl…

    …ing promoted properties (jrmajor, keradus)
    
    This PR was squashed before being merged into the 2.18 branch.
    
    Discussion
    ----------
    
    NullableTypeDeclarationForDefaultNullValueFixer - fix handling promoted properties
    
    Fixes #5547
    
    **Before:**
    ```diff
      public function __construct(
    -     public ?array $x = null,
    -     ?array $y = null,
    +     public array $x = null,
    +     array $y = null,
      ) { }
    ```
    **After:**
    ```diff
      public function __construct(
          public ?array $x = null,
    -     ?array $y = null,
    +     array $y = null,
      ) { }
    ```
    
    Commits
    -------
    
    077eb6a NullableTypeDeclarationForDefaultNullValueFixer - fix handling promoted properties
    keradus committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    c64d3f2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    54dbfc3 View commit details
    Browse the repository at this point in the history
  4. bug #5464 NativeFunctionInvocationFixer - PHP 8 attributes (HypeMC, k…

    …eradus)
    
    This PR was squashed before being merged into the 2.18 branch.
    
    Discussion
    ----------
    
    NativeFunctionInvocationFixer - PHP 8 attributes
    
    The `NativeFunctionInvocationFixer` removes the leading `\` from attributes when strict is set to `true` which breaks the code.
    
    Config:
    ```php
    'native_function_invocation' => [
        'strict' => true,
    ],
    ```
    
    Result:
    ```diff
    -#[\Attribute(\Attribute::TARGET_CLASS)]
    +#[Attribute(\Attribute::TARGET_CLASS)]
    class Foo {}
    ```
    
    This PR should fix the problem.
    
    Commits
    -------
    
    54dbfc3 NativeFunctionInvocationFixer - PHP 8 attributes
    keradus committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    d3aaf70 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    55a9991 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5d2d99d View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2021

  1. bug #5421 PsrAutoloadingFixer - Fix PSR autoloading outside configure…

    …d directory (kelunik, keradus)
    
    This PR was merged into the 2.18 branch.
    
    Discussion
    ----------
    
    PsrAutoloadingFixer - Fix PSR autoloading outside configured directory
    
    Fixes amphp/php-cs-fixer-config#5.
    
    Commits
    -------
    
    5d2d99d PsrAutoloadingFixer - call realpath only once
    55a9991 PsrAutoloadingFixer - Fix PSR autoloading outside configured directory
    keradus committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    06f764e View commit details
    Browse the repository at this point in the history
Loading