fix(update): 更新时会重复触发 UpdateRestart 方法#2267
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses Issue #2233, which involves fixing duplicate triggering of the UpdateRestart method during the launcher update process. The issue occurs when the update mechanism calls UpdateRestart, which then triggers the program end sequence, potentially causing the update restart logic to be invoked multiple times.
Changes:
Unable to determine specific changes without access to the diff.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ruattd
previously requested changes
Jan 21, 2026
Contributor
ruattd
left a comment
There was a problem hiding this comment.
给你的 hasUpdated 加个 param 注释，另外我觉得它应该叫 isUpdating 而不是 hasUpdated，这俩时态差距有点大
Contributor
Author
|
好 |
ruattd
approved these changes
Jan 21, 2026
pynickle
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2233
如果有更好的解决方案可以提出建议