Skip to content

Bump docker-maven-plugin to 0.48.0#2459

Merged
ihrasko merged 1 commit intoPANTHEONtech:mainfrom
PeterSuna:bumpDockerMaven
Nov 28, 2025
Merged

Bump docker-maven-plugin to 0.48.0#2459
ihrasko merged 1 commit intoPANTHEONtech:mainfrom
PeterSuna:bumpDockerMaven

Conversation

@PeterSuna
Copy link
Contributor

@PeterSuna PeterSuna commented Nov 26, 2025

@gemini-code-assist
Copy link

gemini-code-assist bot commented Nov 26, 2025

Summary of Changes

Hello @PeterSuna, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a routine but important update to the docker-maven-plugin across two key application modules. By upgrading the plugin to version 0.48.0, the projects will benefit from the latest enhancements, bug fixes, and security patches provided by the plugin, ensuring more robust and efficient Docker image builds. This keeps the build infrastructure current and aligned with recent developments in the fabric8io ecosystem.

Highlights

  • Dependency Update: The docker-maven-plugin has been updated from version 0.45.1 to 0.48.0.
  • Affected Modules: This plugin version bump impacts the lighty-rcgnmi-app-docker and lighty-rnc-app-docker modules, specifically their pom.xml files.
  • JIRA Reference: This change is associated with JIRA ticket LIGHTY-394.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 26, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the docker-maven-plugin from version 0.45.1 to 0.48.0 in two modules. The update itself is fine. However, I've noticed that the plugin version is hardcoded in both pom.xml files. For better maintainability, I've recommended centralizing the version management, for example, in a parent POM. This will make future dependency updates easier and less error-prone.

@PeterSuna PeterSuna closed this Nov 27, 2025
@PeterSuna PeterSuna reopened this Nov 27, 2025
@ihrasko ihrasko merged commit d835fb4 into PANTHEONtech:main Nov 28, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PeterSuna @ihrasko