Fix incorrect artifactId in documentation#2406
Conversation
Summary of ChangesHello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical documentation error by updating an incorrect Maven artifact reference in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request corrects an incorrect artifact ID and group ID in the lighty-examples/README.md documentation. The change replaces the non-existent io.lighty.core.parents:lighty-dependency-artifacts with the correct Bill of Materials (BOM) artifact io.lighty.core:lighty-bom. I have verified against other pom.xml files in the repository that this change is correct. The pull request is a good documentation fix and I have no further comments.
2281639 to
2cae18b
Compare
The artifact io.lighty.core.parents:lighty-dependency-artifacts mentioned in this documentation is incorrect. Based on other pom.xml files, users should import a Bill of Materials (BOM) like io.lighty.core:lighty-bom to manage dependencies. JIRA: LIGHTY-392 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
The artifact io.lighty.core.parents:lighty-dependency-artifacts mentioned in this documentation is incorrect. Based on other pom.xml files, users should import a Bill of Materials (BOM) like io.lighty.core:lighty-bom to manage dependencies.
JIRA: LIGHTY-392