Revert "Bump netty to 4.1.124.Final"#2340
Conversation
odlparent 14.1.1 uses newer version 4.2.2.Final making this commit redundant: https://github.com/opendaylight/odlparent/blob/v14.1.1/odlparent-dependency-check/pom.xml#L99 This reverts commit 26e1fe7 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
There was a problem hiding this comment.
Summary of Changes
Hello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a redundant dependency declaration by reverting a previous commit that updated the Netty library. The change ensures that the project correctly inherits the Netty version from its parent "odlparent" project, streamlining dependency management and preventing potential version conflicts.
Highlights
- Dependency Management: Reverted the previous commit that explicitly bumped the Netty version to "4.1.124.Final".
- Reason for Revert: The "odlparent" project, specifically version "14.1.1", already provides a newer Netty version ("4.2.2.Final"), making the explicit version declaration in this project redundant.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request reverts a previous commit that introduced a manual override for the Netty dependency version. The reason for this revert is that the odlparent dependency has been updated to version 14.1.1, which itself manages a newer version of Netty. By removing the now-redundant override, the project will correctly inherit the Netty version from odlparent, simplifying dependency management and avoiding potential conflicts. This is a good housekeeping change that improves the project's build configuration.
odlparent 14.1.1 uses newer version 4.2.2.Final making this commit redundant:
https://github.com/opendaylight/odlparent/blob/v14.1.1/odlparent-dependency-check/pom.xml#L99
This reverts commit 26e1fe7