Manage RNC and RCGNMI docker artifacts by maven-release-plugin#2270
Manage RNC and RCGNMI docker artifacts by maven-release-plugin#2270ihrasko merged 3 commits intoPANTHEONtech:mainfrom
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @ihrasko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on enhancing the release process for the RNC and RCGNMI Docker applications by integrating them more seamlessly with the maven-release-plugin. It involves updating project versions across the board and fine-tuning Maven configurations to manage Docker artifacts outside the traditional Maven repository deployment, aiming for a more streamlined and automated release workflow.
Highlights
- Maven Release Automation: This PR configures the
maven-release-pluginto enable simplified release preparation and performance for RNC and RCGNMI Docker artifacts, reducing manual steps to just two Maven commands. - Docker Artifact Management: The
lighty-rcgnmi-app-dockerandlighty-rnc-app-dockermodules are now explicitly excluded from the standard Maven release process, indicating their Docker image lifecycle is managed separately. Amaven.deploy.skipproperty was added to these modules to prevent their deployment to a Maven repository. - Version Updates: Across the entire project, all
pom.xmlfiles have been updated to reflect a new snapshot version, moving from22.0.0-SNAPSHOTto22.1.0-SNAPSHOT. This includes parent POMs, module versions, and dependency management entries. - SCM Configuration: The
lighty-controller-springboot-netconfexample module now explicitly sets its SCM tag toHEAD, which might be relevant for its specific release or development flow.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the project version across all modules and configures the maven-release-plugin to handle RNC and RCGNMI Docker artifacts. The changes look good and align with the goal of streamlining the release process for Docker images.
| <artifactId>lighty-rcgnmi-app-docker</artifactId> | ||
| <artifactId>lighty-rcgnmi-app</artifactId> |
There was a problem hiding this comment.
For better maintainability, it's a good practice to keep lists like this sorted alphabetically. Could you please reorder the artifactIds in this section?
<artifactId>lighty-rcgnmi-app</artifactId>
<artifactId>lighty-rcgnmi-app-aggregator</artifactId>
<artifactId>lighty-rcgnmi-app-docker</artifactId>
<artifactId>lighty-resources-aggregator</artifactId>
<artifactId>lighty-rnc-aggregator</artifactId>
<artifactId>lighty-rnc-app</artifactId>
<artifactId>lighty-rnc-app-docker</artifactId>
There was a problem hiding this comment.
Already sorted by vim's sorted function.
| <scm> | ||
| <tag>HEAD</tag> | ||
| </scm> |
There was a problem hiding this comment.
This pom.xml doesn't inherit from the project's parent POM that defines the SCM information. While the minimal <scm> block might work when running the release from the root, it's good practice to include the full SCM information for consistency and to allow this module to be released independently if needed. Please consider adding the connection, developerConnection, and url tags.
<scm>
<connection>scm:git:https://github.com/PANTHEONtech/lighty.git</connection>
<developerConnection>scm:git:https://github.com/PANTHEONtech/lighty.git</developerConnection>
<url>https://github.com/PANTHEONtech/lighty</url>
<tag>HEAD</tag>
</scm>
lighty-controller-springboot-netconf does not inherit SCM tag, add it explicitly. Add developers and licenses sections as well. JIRA: LIGHTY-374 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Add lighty-rnc-app-docker and lighty-rcgnmi-app-docker to excluded artifacts for maven central publish plugin. JIRA: LIGHTY-374 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Skip deployment phase for lighty-rnc-app-docker and lighty-rcgnmi-app-docker artifacts. JIRA: LIGHTY-374 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
This patch enables us to prepare release with just (+ adjusting documentation and READMEs):