feat: add options to enable/disable spurious sleep removal#272
Merged
feat: add options to enable/disable spurious sleep removal#272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces functionality to remove spurious sleep periods from activity classification. It adds new parameters to control this behavior and updates the relevant functions to incorporate these changes. The primary focus is on improving the accuracy of activity classification by filtering out short, potentially erroneous sleep periods.
Enhancements to Activity Classification:
--removeSpuriousSleepand--removeSpuriousSleepTolarguments toaccProcess.pyto enable and configure spurious sleep removal. The default behavior removes sleep periods shorter than 60 minutes. (src/accelerometer/accProcess.py, src/accelerometer/accProcess.pyR178-R186)activityClassificationFunction: IncorporatedspuriousSleepRemovalandspuriousSleepTolparameters to conditionally apply spurious sleep removal during activity classification. (src/accelerometer/classification.py, [1] [2]Improvements to Spurious Sleep Removal Logic:
removeSpuriousSleepFunction: Updated thesleepTolparameter to accept an integer representing minutes instead of a string duration, simplifying its usage. (src/accelerometer/classification.py, [1] [2]Integration with Activity Summarization:
getActivitySummary: AddedremoveSpuriousSleepandremoveSpuriousSleepTolparameters to allow spurious sleep removal during activity summary generation. These parameters are passed down to theactivityClassificationfunction. (src/accelerometer/summarisation.py, [1] [2] [3]Codebase-Wide Updates:
deleteIntermediateFilesandgetActivitySummary, to maintain consistency. (src/accelerometer/accProcess.py, [1];src/accelerometer/summarisation.py, [2]These changes collectively enhance the robustness of activity classification by addressing spurious sleep periods, improving the reliability of downstream analyses.