Fixed the "Compile All Shaders" button #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05d9c36 to
c70e3b9
Compare
c70e3b9 to
b3ea82f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "Compile All Shaders" button was broken, and resulted in a bunch of errors being displayed. This was due to the
pathParserCallbacknot being provided.This PR fixes that issue by using
ReloadResourceinstead ofRecompile, which internally callsRecompileand automatically provides thepathParserCallbackto theShaderLoader, as well as properly enabling shader compilation logging.Also updated an
OVLOG_INFOthat was supposed to be anOVLOG_ERRORin the shader compilation code.Screenshot(s)
OvEditor_Q17R82cWZF.mp4