Skip to content

Added serialization (ini) of editor settings #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adriengivry merged 1 commit into from
Feb 15, 2025
Merged

Added serialization (ini) of editor settings #329

adriengivry merged 1 commit into from
Feb 15, 2025

Conversation

@adriengivry
Copy link
Member

@adriengivry adriengivry commented Nov 22, 2024 •
edited
Loading

Description

  • Serialize/deserialize settings present in EditorSettings respectively on editor start and stop
  • Doesn't cover all the settings yet, as some exposed in the menu bar don't rely on EditorSettings (i.e. grid color, camera speed) Follow up issue: Update EditorSettings to include ALL menu bar settings #353

Related Issues

Fixes #23

@adriengivry adriengivry added QoL Quality of Life : Something that can improve users productivity Feature Editor Something relative with the editor labels Nov 22, 2024
@adriengivry adriengivry self-assigned this Nov 22, 2024
@adriengivry adriengivry changed the title Added serialization (ini) of editor settings [WIP] Added serialization (ini) of editor settings Nov 22, 2024
@adriengivry adriengivry force-pushed the feature/editor_settings_save branch 2 times, most recently from eebfbca to ac9bc43 Compare February 10, 2025 00:56
@adriengivry adriengivry mentioned this pull request Feb 10, 2025
Open
@adriengivry adriengivry changed the title [WIP] Added serialization (ini) of editor settings Added serialization (ini) of editor settings Feb 10, 2025
@adriengivry adriengivry marked this pull request as ready for review February 10, 2025 01:00
@adriengivry
Added serialization (ini) of editor settings
cdd8dbc 
* serialize/deserialize settings present in EditorSettings respectively on editor start and stop
* doesn't cover all the settings yet, as some exposed in the menu bar don't rely on EditorSettings
@adriengivry adriengivry force-pushed the feature/editor_settings_save branch from ac9bc43 to cdd8dbc Compare February 10, 2025 01:01
@adriengivry adriengivry changed the base branch from develop to main February 14, 2025 15:30
@adriengivry adriengivry merged commit 11da2ca into main Feb 15, 2025
1 check passed
@adriengivry adriengivry deleted the feature/editor_settings_save branch February 15, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@litelawliet litelawliet litelawliet approved these changes

@maxbrundev maxbrundev Awaiting requested review from maxbrundev

@BenjaminViranin BenjaminViranin Awaiting requested review from BenjaminViranin

Assignees

@adriengivry adriengivry

Labels

Editor Something relative with the editor QoL Quality of Life : Something that can improve users productivity

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Save editor settings

3 participants

@adriengivry @litelawliet