Skip to content

Updating C++ Version from C++17 to C++20 #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adriengivry merged 2 commits into from
Feb 11, 2025
Merged

Updating C++ Version from C++17 to C++20 #311

adriengivry merged 2 commits into from
Feb 11, 2025

Conversation

@adriengivry
Copy link
Member

@adriengivry adriengivry commented Nov 9, 2024 •
edited
Loading

Description

Updated C++ version from 17 to 20.
Also had to add a constructor to the ReferenceOrValue class to work with T& again (no implicit conversion from T& to OptRef<T>).

Related Issues

Fixes #294

@adriengivry adriengivry self-assigned this Nov 22, 2024
@adriengivry adriengivry added Optimization Optimization related stuff Project Configuration Anything related to setuping our projects labels Nov 22, 2024
@adriengivry adriengivry changed the title Updating C++ Version from C++17 to C++20 [WIP] Updating C++ Version from C++17 to C++20 Nov 22, 2024
@adriengivry adriengivry force-pushed the feature/updating_cpp_17_to_20 branch from 5f55b6e to 68d39a1 Compare February 10, 2025 00:42
@adriengivry adriengivry changed the title [WIP] Updating C++ Version from C++17 to C++20 Updating C++ Version from C++17 to C++20 Feb 10, 2025
@adriengivry adriengivry marked this pull request as ready for review February 10, 2025 00:44
@adriengivry adriengivry merged commit 5b33fdd into develop Feb 11, 2025
1 check passed
@adriengivry adriengivry deleted the feature/updating_cpp_17_to_20 branch February 11, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@litelawliet litelawliet litelawliet approved these changes

@maxbrundev maxbrundev Awaiting requested review from maxbrundev

@BenjaminViranin BenjaminViranin Awaiting requested review from BenjaminViranin

Assignees

@adriengivry adriengivry

Labels

Optimization Optimization related stuff Project Configuration Anything related to setuping our projects

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider updating Overload C++ version from 17 to 20

3 participants

@adriengivry @litelawliet