OvRendering Rework: Better Rendering capabilities, less redundancy, and code clean-up
#277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e256313 to
201f282
Compare
* moved material to OvRendering * re-organizing renderer code * moved driver-related code to driver
* started working on implementing proper render features * lighting and engine UBO render features added * working on entity base class for OvRendering * dealing with camera issues * added OvSandbox applicaton to test rendering changes
201f282 to
840edbf
Compare
The way Our UBO binding was broken, resulting in nothing showing up on screen when using multiple UBOs!!!
* descriptor system added to the CompositeRenderer * asset view now support orbital rotations * asset view now create a scene where it stores its actors including lights, so we can re-use the SceneRenderer * WIP DebugSceneRenderer
* views can now show some basic debug display (lights, grid, camera)
Trying to break down the DebugSceneRenderer into render features
* OptRef added * Describable base class added * Updated actor picking
Still need some work, rendering is kind-of broken right now :)
6e068b2 to
7970265
Compare
Still need some work for resources (buffers, textures) to be completely independent of the graphics API
maxbrundev
approved these changes
Mar 15, 2024
litelawliet
requested changes
Mar 18, 2024
Contributor
litelawliet
left a comment
There was a problem hiding this comment.
There is a visual issue when selecting an object having children (with a mesh to render), all segments of all visible triangles are highlighted:
Member
Author
Fixed ✅ |
litelawliet
approved these changes
Mar 18, 2024
This was referenced Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initiative to rework
OvRenderingto improve its modularity and prepare the field for upcoming work (such as shadow casting).This work includes:
MaterialfromOvCoretoOvRendering(The serialization part of material remains inOvCorefor now)RenderertoDriverStateMaskfor materials (take up less memory)SceneRenderer(ECS-specific)OvGame,OvEditorandOvCore.Lightentity, such asCamera(moved fromLowRenderer, andDrawable, which represent an entity that can be visually drawn).PipelineState, which is an 8 bytes struct that contains information about the graphics context state. Rendering functions pass instances ofPipelineStateto each other by copy, allowing for hierarchical pipeline state updates, i.e. each scope can modify the pipeline state without affecting the level above. Lowest level functions (driver-level) are responsible for requesting the graphics backend to update its internal state. The driver also ensure that no unnecessary state change is performed (this is done by keeping track of the current state of the context, and comparing state change requests with the current state).HALnamespace with aGraphicsAPIclass has been added. This doesn't cover resources such a buffers, textures, and shaders, which individually hold graphics API-specific code (this code should be moved to the HAL in the future).Related Issues
Screenshots
Renderer updated architecture
