Skip to content

Added virtual destructor for OvUI::API:IDrawable #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adriengivry merged 1 commit into from
Oct 4, 2020
Merged

Added virtual destructor for OvUI::API:IDrawable #152

adriengivry merged 1 commit into from
Oct 4, 2020

Conversation

@litelawliet
Copy link
Contributor

@litelawliet litelawliet commented Oct 4, 2020 •
edited
Loading

Fixes #151
That very small fix should guarantee a proper destruction of IDrawable derived-classes

@adriengivry adriengivry merged commit c770b67 into develop Oct 4, 2020
@adriengivry adriengivry deleted the fix/idrawable_virtual_destructor_missing branch October 4, 2020 01:50
@litelawliet litelawliet mentioned this pull request Oct 4, 2020
Closed
@adriengivry adriengivry mentioned this pull request Oct 4, 2020
Closed
@adriengivry adriengivry mentioned this pull request Nov 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adriengivry adriengivry adriengivry approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API:IDrawable virtual destructor non-implemented, potential undefined behaviour

3 participants

@litelawliet @adriengivry