Fixing assimp unit scaling #139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the wrong unit scaling issue with FBX models.
Currently, in projects made with Overload, we tend to counter-scale our objects with a 0.01 scale to compensate the centimeters to meters conversion.
The idea here is to add a flag to automatically convert these FBX using centimeters as the default unit to meters (In order to avoid manual counter-scaling).
Do note that this PR will break scenes made with previous version of Overload. If you want to convert your scene to correctly behave with this new scaling system, you'll have to disable
GLOBAL_SCALEin your model asset properties.This PR introduce several flags for models:
TODO:
EModelParserFlagsFixes #136