fix: Guard invalid CefSharp frames in load callbacks#538
Merged
Conversation
valarnin
approved these changes
May 29, 2026
|
I'm not sure if this will actually fix the issue since it's possible that this is caused by cross-thread concurrency/updates, but I'll approve it since it's not hurting anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user reported an exception from
HtmlRenderer:On that user's PC, the error appears to occur after the ACT main form has loaded, and only when the game is running.
This PR guards
FrameLoadStartandFrameLoadEndagainst invalid frames, but the exact reason that causes the invalid frame is still unclear.