7.0 - Fix Combatant struct#360
Merged
Merged
Conversation
9 tasks
wexxlee
approved these changes
Jun 29, 2024
wexxlee
left a comment
Collaborator
There was a problem hiding this comment.
Gave this a workout and seems to be fine to me. Defer to you if you want to test more before merging or merge as-is and see if anything crops up later.
| [FieldOffset(0xC70)] | ||
| public byte WeaponId; | ||
|
|
||
| // TODO: Verify for 7.0. Could potentially be 0xD50, 0xF30, or 0x1110 |
Collaborator
There was a problem hiding this comment.
Tested and this seems to be right (or at least is returning the expected data).
Author
|
The ID is in all three offsets. Needs tested for e.g. enemy combatants to
ensure that we have the correct field that only gets set for player actors.
…On Sat, Jun 29, 2024, 10:50 Wexx ***@***.***> wrote:
***@***.**** approved this pull request.
Gave this a workout and seems to be fine to me. Defer to you if you want
to test more before merging or merge as-is and see if anything crops up
later.
------------------------------
In OverlayPlugin.Core/MemoryProcessors/Combatant/CombatantMemory70.cs
<#360 (comment)>
:
> + [FieldOffset(0x1D2)]
+ public ushort MaxCP;
+
+ [FieldOffset(0x1D4)]
+ public short TransformationId;
+
+ [FieldOffset(0x1DA)]
+ public byte Job;
+
+ [FieldOffset(0x1DB)]
+ public byte Level;
+
+ [FieldOffset(0xC70)]
+ public byte WeaponId;
+
+ // TODO: Verify for 7.0. Could potentially be 0xD50, 0xF30, or 0x1110
Tested and this seems to be right (or at least is returning the expected
data).
—
Reply to this email directly, view it on GitHub
<#360 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABOWBLTOVHEEX4VFTAEH4MDZJ3CUDAVCNFSM6AAAAABKCXGSP6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNBZGY2TIMJXG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs more testing. My brain's fried, so I'm not even sure if I tested all the properties.
Also finally dropped
MonsterTypeandAggressionStatussince we haven't tracked them down in like an entire expansion.