7.0 - Fix Memory Signatures#359
Merged
Merged
Conversation
9 tasks
wexxlee
reviewed
Jun 29, 2024
Comment on lines
+6
to
+8
| interface IJobGaugeMemory70 : IJobGaugeMemory { } | ||
|
|
||
| partial class JobGaugeMemory70 : JobGaugeMemory, IJobGaugeMemory70 |
Collaborator
There was a problem hiding this comment.
I think this needs to be added to JobGaugeMemoryManager?
Author
|
I held off on adding this until we have structs for PCT and VPR available.
The 6.5 code works fine for 7.0 but the new jobs should only be added to
the 7.0 code.
…On Sat, Jun 29, 2024, 10:44 Wexx ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In OverlayPlugin.Core/MemoryProcessors/JobGauge/JobGauge70.cs
<#359 (comment)>
:
> + interface IJobGaugeMemory70 : IJobGaugeMemory { }
+
+ partial class JobGaugeMemory70 : JobGaugeMemory, IJobGaugeMemory70
I think this needs to be added to JobGaugeMemoryManager?
—
Reply to this email directly, view it on GitHub
<#359 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABOWBLV2HF4O7Z6XBED6MBLZJ3B6RAVCNFSM6AAAAABKCVICKKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNBZGY2TENZVGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
wexxlee
approved these changes
Jun 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.