refactor: use the SDK's WebSocket Upgrade() function#234
Merged
Conversation
fortuna
reviewed
Jan 30, 2025
| defer wsConn.Close() | ||
| ctx, contextCancel := context.WithCancel(context.Background()) | ||
| defer contextCancel() | ||
| conn := &replaceAddrConn{StreamConn: websocket.WrapConn(wsConn), raddr: &net.TCPAddr{IP: net.ParseIP(r.RemoteAddr)}} |
There was a problem hiding this comment.
Doesn't wsConn already have the right remote address because of handlers.ProxyHeaders?
Author
There was a problem hiding this comment.
No, handlers.ProxyHeaders only moves the client IP into the request's RemoteAddr. The wsConn.RemoteAddr() is not altered.
2aa225f to
a41761c
Compare
Upgrade() func
Upgrade() funcUpgrade() function
fortuna
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on OutlineFoundation/outline-sdk#366.