fix: remove deadlock in multiPacketListener#211
Merged
Conversation
70cf8f8 to
a308b51
Compare
fortuna
reviewed
Sep 16, 2024
fortuna
reviewed
Sep 18, 2024
5bb378d to
ff1f078
Compare
fortuna
approved these changes
Sep 18, 2024
fortuna
left a comment
There was a problem hiding this comment.
I think we should still check the if the readCh is closed, but otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
multiPacketListenerandvirtualPacketConnare prone to deadlocks during concurrentReadFrom()andClose()operations. A deadlock when closing connections concurrently with ongoing read operations is preventing the config from getting reloaded on receiving multipleSIGHUPsignals.