RMET-3602 ::: Support 16KB page size devices#1
Merged
OS-pedrogustavobilro merged 25 commits intomasterfrom Dec 10, 2024
Merged
Conversation
Up to Android 14. Failing to compile with compileSdk=35 and edge-to-edge (targerSdkVersion=35) was fixed in cordova plugin, not here. References: - https://outsystemsrd.atlassian.net/browse/RMET-3602 - https://outsystemsrd.atlassian.net/wiki/spaces/RDME/pages/4426137659/iOS+18+Android+15+Assessment
12 tasks
alexgerardojacinto
approved these changes
Dec 10, 2024
| #Thu Nov 14 17:42:41 WET 2024 | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.0.2-bin.zip |
There was a problem hiding this comment.
Shouldn't we point to a newer version than 7.0.2? Also, shouldn't we point to an all distribution instead of a bin?
Author
There was a problem hiding this comment.
I'm not sure why I didn't update at least the minor version of Gradle and AGP. If I recall there was some issue when I tried to update the version, but I tried just now and it was fine.
Actually ended up updating gradle to the latest version, fixed the breaking changes, weren't that many.
As for using all instead of bin, yeah I see no issue with that, I don't think it makes that much of a difference for us, it just comes with the documentation instead of just binaries - but yeah I changed it
Done in fc7a46b
Also involved some fixes given there were breaking changes with the update of gradle / agp (7.X to 8.X) - Update JDK from 11 to 17 - Update build tools version to latest - Add namespace to gradle modules - Explicitly enable buildConfig in card.io module - Update way of setting classifier for gradle tasks References: - https://outsystemsrd.atlassian.net/browse/RMET-3602 - https://outsystemsrd.atlassian.net/wiki/spaces/RDME/pages/4426137659/iOS+18+Android+15+Assessment
Used by the upstream card.io repo, not needed here. Fixes snyk issue. References: - https://outsystemsrd.atlassian.net/browse/RMET-3602 - https://outsystemsrd.atlassian.net/wiki/spaces/RDME/pages/4426137659/iOS+18+Android+15+Assessment
OS-ricardomoreirasilva
approved these changes
Dec 10, 2024
Merged
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the Android build scripts, configuration, and source code for the Card IO Android SDK, to be built with support for 16KB page size devices, introduced in Android 15.
This involved mainly
Other changes basically involved code cleanups and some dependency updates.
Context
Type of changes
Platforms affected
Checklist
RNMT-XXXX <title>