Skip to content

feature: add hap asset to the cli#997

Merged
3asm merged 2 commits intomainfrom
feature/add_hap_asset_to_cli
Apr 3, 2026
Merged

feature: add hap asset to the cli#997
3asm merged 2 commits intomainfrom
feature/add_hap_asset_to_cli

Conversation

@mouadostor
Copy link
Copy Markdown
Contributor

@mouadostor mouadostor commented Apr 3, 2026 •
edited
Loading

Changes:

  • add harmony hap asset support to the cli

Before:

image

Now:

image

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 46.32588% with 168 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.27%. Comparing base (89c01ca) to head (9223830).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/ostorlab/cli/scan/run/assets/harmonyos_aab.py 21.62% 29 Missing ⚠️
src/ostorlab/cli/scan/run/assets/harmonyos_apk.py 21.62% 29 Missing ⚠️
src/ostorlab/cli/scan/run/assets/harmonyos_app.py 21.62% 29 Missing ⚠️
src/ostorlab/cli/scan/run/assets/harmonyos_hap.py 21.62% 29 Missing ⚠️
src/ostorlab/cli/scan/run/assets/harmonyos_rpk.py 21.62% 29 Missing ⚠️
...rc/ostorlab/cli/scan/run/assets/harmonyos_store.py 39.28% 17 Missing ⚠️
src/ostorlab/cli/scan/run/assets/__init__.py 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #997      +/-   ##
==========================================
- Coverage   65.62%   65.27%   -0.35%     
==========================================
  Files         389      401      +12     
  Lines       16849    17162     +313     
==========================================
+ Hits        11057    11203     +146     
- Misses       5792     5959     +167

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

1l0c
1l0c requested changes Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@1l0c 1l0c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also add these: harmonyos-store, harmonyos-apk, harmonyos-aab, harmonyos-app and harmonyos-rpk

amine3
amine3 requested changes Apr 3, 2026
View reviewed changes
Comment thread src/ostorlab/cli/scan/run/assets/__init__.py
@mouadostor mouadostor marked this pull request as draft April 3, 2026 12:01
@mouadostor mouadostor marked this pull request as ready for review April 3, 2026 12:10
@mouadostor mouadostor requested a review from a team as a code owner April 3, 2026 12:10
@mouadostor mouadostor requested review from 1l0c and amine3 April 3, 2026 12:10
@3asm 3asm merged commit c60ea54 into main Apr 3, 2026
10 of 14 checks passed
@amine3 amine3 deleted the feature/add_hap_asset_to_cli branch April 3, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3asm 3asm 3asm approved these changes

@amine3 amine3 amine3 approved these changes

@1l0c 1l0c Awaiting requested review from 1l0c

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mouadostor @3asm @amine3 @1l0c