Skip to content

feature: Add message subcommand to scan run for generic protobuf injection#996

Merged
3asm merged 10 commits intomainfrom
feat/message-cli-subcommand
Apr 2, 2026
Merged

feature: Add message subcommand to scan run for generic protobuf injection#996
3asm merged 10 commits intomainfrom
feat/message-cli-subcommand

Conversation

@yami-ost
Copy link
Copy Markdown
Contributor

Summary

  • Add oxo scan run message subcommand that injects any protobuf message onto the bus by selector and proto text format file
  • Add src/ostorlab/assets/message.py — generic Message asset that holds a dynamic selector and pre-computed proto bytes
  • Leverages the existing serializer's _find_package_name to dynamically resolve the proto class from the selector

Usage

oxo scan run --agent=agent/ostorlab/nebula message \
  --selector "v3.report.risk" \
  --textproto risk.textproto

Where risk.textproto:

rating: "HIGH"
description: "Server exposed to the internet"

@yami-ost yami-ost marked this pull request as ready for review March 27, 2026 09:18
@yami-ost yami-ost requested a review from a team as a code owner March 27, 2026 09:18
@yami-ost yami-ost marked this pull request as draft March 27, 2026 09:35
…eat/message-cli-subcommand

# Conflicts:
#	src/ostorlab/cli/scan/run/assets/__init__.py
@yami-ost yami-ost marked this pull request as ready for review March 27, 2026 14:42
@3asm 3asm marked this pull request as draft March 30, 2026 14:15
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 69.15888% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.63%. Comparing base (4c5d7d1) to head (28a596f).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/ostorlab/cli/scan/run/assets/message.py 46.51% 23 Missing ⚠️
src/ostorlab/assets/message.py 10.00% 9 Missing ⚠️
src/ostorlab/cli/scan/run/assets/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #996      +/-   ##
==========================================
+ Coverage   65.55%   65.63%   +0.07%     
==========================================
  Files         386      389       +3     
  Lines       16742    16849     +107     
==========================================
+ Hits        10975    11058      +83     
- Misses       5767     5791      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yami-ost yami-ost marked this pull request as ready for review April 1, 2026 13:19
@3asm 3asm marked this pull request as draft April 2, 2026 07:55
@yami-ost yami-ost marked this pull request as ready for review April 2, 2026 10:00
MouadAO
MouadAO previously approved these changes Apr 2, 2026
Copy link
Copy Markdown
Member

@MouadAO MouadAO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@1l0c 1l0c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@3asm 3asm merged commit 1e6cfc4 into main Apr 2, 2026
12 of 14 checks passed
@3asm 3asm deleted the feat/message-cli-subcommand branch April 2, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants