Skip to content

feature: Add risk CLI subcommand for injecting risk messages onto the bus#995

Merged
3asm merged 17 commits intomainfrom
feat/risk-cli-subcommand
Apr 1, 2026
Merged

feature: Add risk CLI subcommand for injecting risk messages onto the bus#995
3asm merged 17 commits intomainfrom
feat/risk-cli-subcommand

Conversation

@yami-ost
Copy link
Copy Markdown
Contributor

Summary

  • Add oxo scan run risk subcommand that injects v3.report.risk messages onto the message bus
  • Support the following options:
    • --severity
    • --description
    • --description-file
    • --ip
    • --domain
    • --link
    • --android-store
    • --ios-store
  • Make --description-file mutually exclusive with --description, allowing the risk description to be provided either inline or from a file

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 76.40751% with 88 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.54%. Comparing base (cd319b1) to head (0825bd3).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/ostorlab/cli/scan/run/assets/risk.py 58.59% 53 Missing ⚠️
src/ostorlab/assets/risk.py 8.10% 34 Missing ⚠️
src/ostorlab/cli/scan/run/assets/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
+ Coverage   65.30%   65.54%   +0.24%     
==========================================
  Files         383      386       +3     
  Lines       16369    16742     +373     
==========================================
+ Hits        10689    10974     +285     
- Misses       5680     5768      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yami-ost yami-ost marked this pull request as ready for review March 26, 2026 17:23
@yami-ost yami-ost requested a review from a team as a code owner March 26, 2026 17:23
Comment thread src/ostorlab/assets/risk.py Outdated
Comment thread src/ostorlab/assets/risk.py Outdated
Comment thread src/ostorlab/assets/risk.py Outdated
Comment thread tests/cli/scan/run/assets/risk_test.py Outdated
Comment thread tests/cli/scan/run/assets/risk_test.py Outdated
@yami-ost yami-ost marked this pull request as draft March 26, 2026 17:28
@yami-ost yami-ost marked this pull request as ready for review March 26, 2026 17:42
m0hamed-ait
m0hamed-ait previously approved these changes Mar 26, 2026
Comment thread src/ostorlab/assets/risk.py
Comment thread src/ostorlab/cli/scan/run/assets/risk.py
Comment thread src/ostorlab/cli/scan/run/assets/risk.py
Comment thread src/ostorlab/cli/scan/run/assets/risk.py
m0hamed-ait
m0hamed-ait previously approved these changes Mar 27, 2026
MouadAO
MouadAO previously approved these changes Mar 27, 2026
Copy link
Copy Markdown
Member

@MouadAO MouadAO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/ostorlab/assets/risk.py Outdated
Comment thread src/ostorlab/assets/risk.py Outdated
Comment thread src/ostorlab/assets/risk.py Outdated
@yami-ost yami-ost marked this pull request as draft March 27, 2026 09:51
@yami-ost yami-ost dismissed stale reviews from MouadAO and m0hamed-ait via d3e968e March 27, 2026 13:23
@yami-ost yami-ost marked this pull request as ready for review March 27, 2026 13:24
Comment thread src/ostorlab/assets/risk.py Outdated
@3asm 3asm merged commit 8b820d4 into main Apr 1, 2026
12 of 14 checks passed
@3asm 3asm deleted the feat/risk-cli-subcommand branch April 1, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants