Fix netfab model repair service in github compilation#10507
Merged
SoftFever merged 3 commits intoOrcaSlicer:mainfrom Aug 24, 2025
Merged
Fix netfab model repair service in github compilation#10507SoftFever merged 3 commits intoOrcaSlicer:mainfrom
SoftFever merged 3 commits intoOrcaSlicer:mainfrom
Conversation
This reverts commit 9e2350c.
SoftFever
approved these changes
Aug 24, 2025
Collaborator
SoftFever
left a comment
There was a problem hiding this comment.
Nice catch!
Thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a build issue in GitHub Actions where STL repair via Netfabb is skipped due to missing Windows SDK detection.
Although local builds work correctly, the GitHub CI output shows:
WIN10SDK_PATH is invalid: C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0\ -- PROJECT_SOURCE_DIR: D:/a/OrcaSlicer/OrcaSlicer C:\Program Files (x86)\Windows Kits\10\Include\10.0.22000.0/winrt/windows.graphics.printing3d.h was not found STL fixing by the Netfabb service will not be compiled Building without Win10 Netfabb STL fixing service support
fix #10461
fix #10463