You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hmmm, I'm not sure if this is the right way to go. Have you checked why the select_preset_by_name function failed?
As far as I can tell, select_preset_by_name is used to sets the "active" or "currently selected" reset, so when the currently selected preset is already the preset that select_preset_by_name is trying to set active, it just returns false and skip the preset selection this->select_preset(idx); . I do not think this method should be used in the case of exporting presets.
I just found out bambu studio "fixed" it by changing (preset_bundle.printers.select_preset_by_name(preset_name, false)) to (preset_bundle.printers.select_preset_by_name(preset_name, true)) which just force it to trigger preset selection and relavant UI rendering then returns true. It also works, but I think it is unnecessary. Both options fixes the export not showing up bug. @SoftFever How would you like this to be implemented?
I just found out bambu studio "fixed" it by changing (preset_bundle.printers.select_preset_by_name(preset_name, false)) to (preset_bundle.printers.select_preset_by_name(preset_name, true)) which just force it to trigger preset selection and relavant UI rendering then returns true. It also works, but I think it is unnecessary. Both options fixes the export not showing up bug. @SoftFever How would you like this to be implemented?
@Azio-Pantheon
Thank you for digging into the issue.
I've reviewed this issue too. We shouldn't remove this if check because doing so would cause problems when selecting a non-current printer. The update compatibility won't work properly if we don't select the printer first.
Setting the "force" parameter to true is the correct way to resolve this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export Preset Bundle->Printer config bundle will not consider the currently selected printer as a valid option. Fixes #10327
Removed this check
(preset_bundle.printers.select_preset_by_name(preset_name,false))`Tests
Tried out the user config in the bug report. If you create and select another printer, you can get Bambu Lab P1S 0.4 nozzle to show up.