Skip to content

Adding support for passing host system AWS_ prefixed variables into runiac container#51

Merged
tiny-dancer merged 1 commit intoOptum:mainfrom
drmmarsunited:main
Feb 24, 2022
Merged

Adding support for passing host system AWS_ prefixed variables into runiac container#51
tiny-dancer merged 1 commit intoOptum:mainfrom
drmmarsunited:main

Conversation

@drmmarsunited
Copy link
Contributor

@drmmarsunited drmmarsunited commented Feb 23, 2022

fix(chore): preventing multiple loops over the same array
feature(AWS_ vars): Adding AWS_ env var support into run container

Proposed changes

Allowing AWS environment variables to be passed to runiac run container, as they were previously restricted to only allow prefixed like: TF_VAR_, ARM_, RUNIAC_.

Common environment variables, as presented in the entrypoint.sh in the AWS hello world starter, demonstrate the need to allow well-known vars to make their way into the container for use.

Issues for these changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, CHANGELOG.md, etc. - if appropriate)

Dependencies and Blockers

I will be making another PR to the AWS hello world repo adding support for the often used AWS_PROFILE env var.

Relevant Links

AWS CLI/SDK Support Environment Variables

Further comments

None

feature(AWS_ vars): Adding AWS_ env var support into run container
9dd03e5 
fix(chore): preventing multiple loops over the same array
@CLAassistant
Copy link

CLAassistant commented Feb 23, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@drmmarsunited
Copy link
Contributor Author

drmmarsunited commented Feb 23, 2022

File changes screen kind of tough to read. Code block now looks like this:

for _, env := range cmd2.Env {
			if strings.HasPrefix(env, "TF_VAR_") {
				cmd2.Args = append(cmd2.Args, "-e", env)
			}

			if strings.HasPrefix(env, "ARM_") {
				cmd2.Args = append(cmd2.Args, "-e", env)
			}

			if strings.HasPrefix(env, "RUNIAC_") {
				cmd2.Args = append(cmd2.Args, "-e", env)
			}

			if strings.HasPrefix(env, "AWS_") {
				cmd2.Args = append(cmd2.Args, "-e", env)
			}
		}

@tiny-dancer
Copy link
Contributor

tiny-dancer commented Feb 24, 2022

LGTM, note the CLA

@github-actions
Copy link

github-actions bot commented Feb 24, 2022 •
edited
Loading

Unit Test Results

  1 files  15 suites   0s ⏱️
54 tests 54 ✔️ 0 💤 0 ❌

Results for commit 06737bc.

♻️ This comment has been updated with latest results.

@drmmarsunited
Copy link
Contributor Author

drmmarsunited commented Feb 24, 2022

LGTM, note the CLA

Had to add another email address to my profile. CLA taken care of now.

@tiny-dancer tiny-dancer merged commit 06737bc into Optum:main Feb 24, 2022
@tiny-dancer
Copy link
Contributor

tiny-dancer commented Feb 24, 2022

@drmmarsunited are you planning any other pull requests or should I cut a release now?

@drmmarsunited
Copy link
Contributor Author

drmmarsunited commented Feb 24, 2022

No others planned right here right now. But I'm sure I'll run into more things as I clear each hurdle 🤣

@tiny-dancer
Copy link
Contributor

tiny-dancer commented Feb 26, 2022

@drmmarsunited released as v0.0.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drmmarsunited @CLAassistant @tiny-dancer