Skip to content
This repository was archived by the owner on Sep 16, 2024. It is now read-only.

Xiph downloads fix#742

Merged
dpatel257 merged 12 commits intoOpenVisualCloud:masterfrom
dpatel257:xiph_downloads_fix
Jun 9, 2021
Merged

Xiph downloads fix#742
dpatel257 merged 12 commits intoOpenVisualCloud:masterfrom
dpatel257:xiph_downloads_fix

Conversation

@dpatel257
Copy link
Copy Markdown

No description provided.

@dpatel257 dpatel257 requested a review from jhou5 June 9, 2021 17:38
# build libogg
ARG LIBOGG_REPO=https://downloads.xiph.org/releases/ogg/libogg-1.3.4.tar.gz
ARG OGG_VER=1.3.5
ARG LIBOGG_REPO=https://github.com/xiph/ogg/releases/download/v${OGG_VER}/libogg-1.3.5.tar.gz
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls. use OGG_VER in libogg-1.3.5.tar.gz

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I saw it is used in m4 file.

# build libvorbis
ARG LIBVORBIS_REPO=https://downloads.xiph.org/releases/vorbis/libvorbis-1.3.7.tar.gz
ARG VORBIS_VER=1.3.7
ARG LIBVORBIS_REPO=https://github.com/xiph/vorbis/releases/download/v${VORBIS_VER}/libvorbis-1.3.7.tar.gz
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls. use VORBIS_VER in libvorbis-1.3.7.tar.gz

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I saw it is used in m4 file.

RUN cd /opt/build && \
wget -O - ${LIBOGG_REPO} | tar xz && \
cd libogg-1.3.4 && \
cd libogg-1.3.5 && \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls. use OGG_VER

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I see it is used in m4 file.

@dpatel257 dpatel257 merged commit ee2fcee into OpenVisualCloud:master Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants