Skip to content

Conversation

@Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Sep 21, 2025

Noticed that this isn't allowed to be matched by configs for some reason. While no current configs use it, it seems reasonable to have in here and I imagine it wouldn't be any issue for performance for configs that have null for it anyways.

This value is output in diag and passed around everywhere already just for some reason not allowed in configs.

@github-actions github-actions bot added plugins Plugin or Plugin API related core OpenTabletDriver core library labels Sep 21, 2025
@Kuuuube Kuuuube changed the title Allow matching FeatureReportLength [0.6.x] Allow matching FeatureReportLength Sep 21, 2025
Copy link
Member

@gonX gonX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a weird oversight. LGTM

@gonX gonX merged commit 87b4530 into OpenTabletDriver:0.6.x Sep 21, 2025
12 checks passed
@gonX gonX added this to the v0.6.6 milestone Sep 21, 2025
@gonX gonX added the needs-forward-port PR or its features needs to be ported to development branch label Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core OpenTabletDriver core library needs-forward-port PR or its features needs to be ported to development branch plugins Plugin or Plugin API related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants