Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies some
[Fact]tests that iterate over tablet configurations into[Theory]tests, properly making individual tests per tested object. This should also speed up the time it takes to run the full test suite, as configurations should only be evaluated a single time per test start, instead of on every individual[Fact]test start.Rewritten the following tests to use
[Theory]with[MemberData]:Configurations_Have_ExistentParsersConfigurations_Verify_Configs_With_SchemaConfigurations_Are_LintedIt also flips the diff side of
Configurations_Are_Lintedas this previously indicated the more useless side of the diff.It also changes the object types to be of
TheoryData<T>instead ofIEnumerable<object[]?>, as suggested in more recent xunit documentation.