Skip to content

Conversation

@gonX
Copy link
Member

@gonX gonX commented Sep 20, 2025

This simplifies some [Fact] tests that iterate over tablet configurations into [Theory] tests, properly making individual tests per tested object. This should also speed up the time it takes to run the full test suite, as configurations should only be evaluated a single time per test start, instead of on every individual [Fact] test start.

Rewritten the following tests to use [Theory] with [MemberData]:

  • Configurations_Have_ExistentParsers
  • Configurations_Verify_Configs_With_Schema
  • Configurations_Are_Linted

It also flips the diff side of Configurations_Are_Linted as this previously indicated the more useless side of the diff.

It also changes the object types to be of TheoryData<T> instead of IEnumerable<object[]?>, as suggested in more recent xunit documentation.

@github-actions github-actions bot added the tests Adds or modifies a unit test label Sep 20, 2025
@gonX gonX force-pushed the 06x-refactor-tests branch from d9fe7f8 to a27f0ac Compare September 20, 2025 20:54
@gonX gonX added this to the v0.6.6 milestone Sep 21, 2025
@gonX gonX added the enhancement New feature or request label Sep 21, 2025
Copy link
Member

@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@gonX gonX merged commit 8937917 into OpenTabletDriver:0.6.x Sep 21, 2025
11 checks passed
@gonX gonX deleted the 06x-refactor-tests branch September 21, 2025 18:22
@gonX gonX added the needs-forward-port PR or its features needs to be ported to development branch label Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request needs-forward-port PR or its features needs to be ported to development branch tests Adds or modifies a unit test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants