[0.6.x] macOS: Track modifier status in OTD, not system #4014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…system CGEventSourceFlagsState does not update flags immediately after an event is posted, leading to unreliable shortcut behavior. This commit modifies the OTD to track modifier status within OTD itself. Since it no longer fetches modifier flags from the system, it cannot combine with other keyboards to form shortcuts. However, this is likely rare, as it is already not possible on macOS to combine keys on different keyboards to form shortcuts. fixes OpenTabletDriver#3889
Kuuuube
approved these changes
Sep 1, 2025
Member
Kuuuube
left a comment
There was a problem hiding this comment.
Code looks good. I don't have a way to test for MacOS but this doesn't look like it will cause any trouble.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CGEventSourceFlagsState does not update flags immediately after an event is posted, leading to unreliable shortcut behavior. This commit modifies the OTD to track modifier status within OTD itself. Since it no longer fetches modifier flags from the system, it cannot combine with other keyboards to form shortcuts. However, this is likely rare, as it is already not possible on macOS to combine keys on different keyboards to form shortcuts.
fixes #3889