[06x] PluginSettingStoreCollection: Check upper bounds #4012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make settings and UI a bit more consistent in case a tablet has its button count reduced. Otherwise, a user having 3 bindings on a 1 binding tablet would still show 3 bindings in the UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make settings and UI a bit more consistent in case a tablet has its button count reduced.
Otherwise, a user having 3 bindings on a 1 binding tablet would still show 3 bindings in the UI, even if the binding is cleared.
It also helps with development in case the developer adds more fields than needed.
The settings aren't auto-saved after displaying the error, so the user has the option to manually back up before saving.