[06x] Adaptive Bindings #4010
Merged
[06x] Adaptive Bindings #4010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to facilitate upcoming changes to adaptive bindings, which would make this class able to handle mouse inputs, which it shouldn't
This is to facilitate an upcoming 'adaptive bindings' feature Alternatively, we would have had to use `IMouseHandler` which would cause some likely undesirable side effects
'field' is a new and preview-only keyword
cda8d24 to
647d000
Compare
Member
Author
|
Rebased a comment out and force pushed. Also hopefully fixed the linting issue (and why doesn't Rider auto fix these for me??) |
Code elsewhere in the project expects this to be present
5 tasks
Member
|
Looks like this is working perfectly on Linux. Still have Windows and MacOS to test. |
Member
|
Seems all good on Windows too. As mentioned, this does not work with Windows Ink plugin currently but there are no extra side effects. Exact same behavior as before this PR. |
Member
|
Confirmed working on MacOS by @TheSevenPens. No problems on all output modes and pen buttons. |
Kuuuube
approved these changes
Sep 6, 2025
This was referenced Sep 7, 2025
This was referenced Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new type of bindings: Adaptive Bindings
Fixes #2510 for 0.6.x
Description
See the issue for what "adaptive means", but the gist of it is that tip binding means left click, and barrel buttons send the signal that equates to a right or middle click respectively. E.g. on Linux Artist Mode a right click is
BTN_STYLUS2.These new bindings are intended to be used when switching between output modes. These functionally replace the Linux Artist Mode bindings. No more juggling profiles for default use cases when switching between output modes 🎉
Additionally, daemon defaults now chooses these adaptive bindings as seen here:
Technical
A new interface
IPenActionhas been added to avoid reusingIMouseHandleras originally suggested in the issue we're solving. Without that change, mouse bindings could still be picked up. To keep compatibility with existing output modes implementingIMouseHandler, this PR also decides that the first tablet pen button correlates to right click, and the 2nd to middle click.Please test thoroughly on non-Linux platforms. The 3 primary modes (artist, absolute, and relative) have been tested on Linux, but a double check is always handy.
Plugin developers making their own output modes may want to add support for these bindings (e.g. Windows Ink). The adaptive bindings supports output modes that implement either
IPenActionHandlerorMouseButtonHandler, and are injected via DI.