Fixed the conflict & Added a missing check (also now re-using a linq query).

I do wonder if it wouldn't be just better to have a new property that stores the updated Metadata to avoid calling GetUpdatedMetadatas twice.

Gave it another test. Clicking the install button for a plugin in the plugin repo doesn't seem to do anything.

Updating a plugin gives Attempted to load the plugin x when it is already loaded. The old plugin is still held onto.

Uninstalling and installing a plugin does seem to work fine here without a restart.

Test case for a plugin that can be updated through the plugin repo: Hover Distance Limiter.zip

1. Can't reproduce the issue,
2. The message is normal as OTD Load the plugins multiple times, every single time you install or update one.

If anything, the message tells me that it indeed worked as it probably loaded the new instance

Try this one out, doubt it will be much different.

It looks mostly good now but the UX filters list (probably tools and output modes too?) doesn't update. Plugins install just fine. Plugins update fine on the daemon's side, files get replaced without any issue.

Test case to easily see this:
Hover Distance Limiter.zip

Hover Distance Limiter with a radial follow dll inside it. When updated it should refresh the filters list to show hover distance limiter instead of still showing radial follow. If you only test this with a plugin update that doesn't add/remove/rename filters this pr should work fine in it's current state.

https://i.imgur.com/nbQDgoo.png

Doesn't happen on my side, list is updated.

Ok nvm, this is an issue.

Alright, I'll give it another test later and approve if I don't see any regressions. The list not refreshing isnt a regression since it was already broken anyways.

AppInfo.PluginManager.GetChildTypes<TSource>() returns the type, meaning it's not removed from somewhere.

It's supposed to be removed, but it seems like a race condition is occuring, and the context sees its Assemblies seemingly magicly modified before the types are removed.

Also, it still loaded in the Daemon side

I'm having an actual massive headache understanding this mess.

Why is the Temp folder only removed if there is nothing inside.
There is something missing but no comments to help.