Skip to content

Handle type being null in the Advanced Binding Editor when getting controls #3783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gonX merged 5 commits into from
Feb 8, 2025
Merged

Handle type being null in the Advanced Binding Editor when getting controls #3783

gonX merged 5 commits into from
Feb 8, 2025

Conversation

@Mrcubix
Copy link
Contributor

@Mrcubix Mrcubix commented Jan 31, 2025 •
edited
Loading

This can happen with certain plugins it seems like, can't reproduce it with mines however.

@gonX gonX added this to the v0.6.6 milestone Jan 31, 2025
@Mrcubix
Copy link
Contributor Author

Mrcubix commented Jan 31, 2025

Nvm able to replicate it with any Bindings plugin using these steps :

  1. Install a binding plugin,
  2. Set a binding using the newly installed plugin,
  3. Save,
  4. Click the Normal Binding display,
  5. Set a new bind not on the same plugin
  6. Save
  7. Uninstall the installed plugin
  8. Exception occurs

@Mrcubix
Copy link
Contributor Author

Mrcubix commented Jan 31, 2025 •
edited
Loading

image

Here is it caught in the IDE with the fix (slight changes were made since this has null as the name)

gonX
gonX requested changes Feb 4, 2025
View reviewed changes
Copy link
Member

@gonX gonX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the logging statement reads a bit weird to me

@Mrcubix @gonX
Update OpenTabletDriver.UX/Controls/PluginSettingStoreEditor.cs
1a918db 
Co-authored-by: Sebastian Jensen <gonx@gonx.dk>
@Mrcubix
Copy link
Contributor Author

Mrcubix commented Feb 4, 2025

Erm, why did they all fail

@Mrcubix
Copy link
Contributor Author

Mrcubix commented Feb 4, 2025

image

Good one gon

gonX
gonX approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@gonX gonX left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The failed change is me being too used to Python 🙈

@gonX gonX merged commit 41682d7 into OpenTabletDriver:0.6.x Feb 8, 2025
9 checks passed
@gonX gonX mentioned this pull request Sep 21, 2025
Closed
5 tasks
@gonX gonX modified the milestones: v0.6.7, v0.6.6 Sep 22, 2025
@gonX gonX added bug Something isn't working plugins Plugin or Plugin API related gui Affects driver GUI and removed plugins Plugin or Plugin API related labels Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gonX gonX gonX approved these changes

Assignees

No one assigned

Labels

bug Something isn't working gui Affects driver GUI

Projects

None yet

Milestone

v0.6.6

Development

Successfully merging this pull request may close these issues.

2 participants

@Mrcubix @gonX