Skip to content

Conversation

@gonX
Copy link
Member

@gonX gonX commented Jan 30, 2025

This ensures that newly merged changes still compile successfully

This ensures that the newly merged changes still compile successfully
@gonX gonX added enhancement New feature or request ci Affects CI needs-forward-port PR or its features needs to be ported to development branch labels Jan 30, 2025
@gonX gonX marked this pull request as ready for review January 30, 2025 20:28
Copy link
Member

@jamesbt365 jamesbt365 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this will have the intended effect on the non default branch but changes look good.

@gonX gonX merged commit da64ce4 into OpenTabletDriver:0.6.x Jan 30, 2025
9 checks passed
@gonX gonX deleted the 06x-build-ci-on-push-for-all-branches branch January 30, 2025 20:33
@gonX gonX removed the needs-forward-port PR or its features needs to be ported to development branch label Jan 31, 2025
@gonX
Copy link
Member Author

gonX commented Jan 31, 2025

Likely not important for master (feature freeze and all that) so just gonna remove the forward port label now that #3787 exists.

@gonX gonX added this to the v0.6.5.1 milestone Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Affects CI enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants