Yank support for 10moons 1060N #3769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, we have to remove support for this tablet as its hindering OpenTabletDriver's development and support for new tablets. Parsing was originally broken because the user had a broken tablet, but this tablet is weird and hard to parse to begin with, it lies about every single spec so its just not something we can reliably have in the driver right now. When people submit changes that fix the parsing, we can add this config file back as long as we change its identifiers to detect ONLY this tablet and not others. There are numerous tablets that detect under this config that really shouldn't: https://discord.com/channels/615607687467761684/723399565780189234/1328233971959595078 https://discord.com/channels/615607687467761684/723399565780189234/1284314755699441758 https://discord.com/channels/615607687467761684/723399565780189234/1270893651052068917 https://discord.com/channels/615607687467761684/723399565780189234/1261241219674279937 https://discord.com/channels/615607687467761684/723399565780189234/1228668011867668542 https://discord.com/channels/615607687467761684/723399565780189234/1192868825952161833
gonX
requested changes
Jan 29, 2025
Member
gonX
left a comment
There was a problem hiding this comment.
LGTM except I think the parser should probably be removed too.
Kuuuube
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, we have to remove support for this tablet as its hindering OpenTabletDriver's development and support for new tablets.
Parsing was originally broken because the user had a broken tablet, but this tablet is weird and hard to parse to begin with, it lies about every single spec so its just not something we can reliably have in the driver right now.
When people submit changes that fix the parsing, we can add this config file back as long as we change its identifiers to detect ONLY this tablet and not others.
There are numerous tablets that detect under this config that really shouldn't:
https://discord.com/channels/615607687467761684/723399565780189234/1328233971959595078
https://discord.com/channels/615607687467761684/723399565780189234/1284314755699441758
https://discord.com/channels/615607687467761684/723399565780189234/1270893651052068917
https://discord.com/channels/615607687467761684/723399565780189234/1261241219674279937
https://discord.com/channels/615607687467761684/723399565780189234/1228668011867668542
https://discord.com/channels/615607687467761684/723399565780189234/1192868825952161833