Skip to content

Conversation

@Mrcubix
Copy link
Contributor

@Mrcubix Mrcubix commented Jan 27, 2025

When a tablet is connected & selected, Profile is always non-null.
A null profile probably either means a tablet isn't selected, or none are available.

image

@gonX gonX added this to the v0.6.5.1 milestone Jan 27, 2025
@gonX gonX added enhancement New feature or request gui Affects driver GUI labels Jan 27, 2025
@gonX gonX self-requested a review January 27, 2025 21:10
@Mrcubix
Copy link
Contributor Author

Mrcubix commented Jan 27, 2025

Additionally, i could disable the tablet & Output Mode dropdowns if neccessary

@Mrcubix
Copy link
Contributor Author

Mrcubix commented Jan 28, 2025

Turns out there is already an existing Placeholder when no tablets are detected or selected, now setting the tabControl selected index approprietely to show that instead of the output mode screen.

Additionally, Tablet dropdown is disable when no tablets are detected.
The output mode's dropdown is also disabled.

Copy link
Member

@gonX gonX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code doesn't look super silly, any weirdness should be getting caught in the upcoming rc anyway.

@gonX gonX merged commit 04f088c into OpenTabletDriver:0.6.x Jan 30, 2025
9 checks passed
@Mrcubix Mrcubix deleted the No-Tablet-Detected branch February 4, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request gui Affects driver GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants