Revert Huion 420 parser change #3757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jamesbt365
approved these changes
Jan 27, 2025
Member
jamesbt365
left a comment
There was a problem hiding this comment.
Would be nice to get some logging in place to see why this happens in the first place as the UCLogicReportParser is just the TabletReportParser with aux.
What black magic is going on here?
gonX
approved these changes
May 4, 2025
Member
gonX
left a comment
There was a problem hiding this comment.
LGTM - I remember the change and was opposed to it, let's see if we can fix this properly instead.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Huion 420 tablets send something that breaks TabletReportParser. Revert of 2bfe918.
Verification https://discord.com/channels/615607687467761684/615611007951306863/1328244031796285481