[06x] RelativeOutputMode warn on reset spam #3750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbt365
reviewed
Jan 27, 2025
Member
Author
|
Apparently saving with a reset time of 0 resets your entire config, this will need fixing before merge. |
Member
Author
|
Fixed the above config reset issue. You can still save with a zero reset time, but loading a profile with a zero resettime just "invisibly" sets it to the default (100ms). I am unable to figure out how to propagate this into the UI. |
… due to too low reset time
Co-authored-by: jamesbt365 <jamesbt365@gmail.com>
4ee669f to
fcf5609
Compare
Member
Author
|
Thinking further about it, I just tore out the zero resettime logic. We can revisit this later - the PR is already a significant improvement over existing behavior. |
jamesbt365
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1947 for 0.6.x. Will warn the user if 10 consecutive resets have been hit. Unsure if this should error instead.
Alternative fixes could have been calculating a ratio, maybe >10%? It would help detect resets times that are marginally too low, especially in the case of 200hz tablets that alternate between 4 and 6ms reports (as seen in 200Hz USB1.1 Wacoms).
Enabling data validation in the UI seems like a larger undertaking: https://gist.github.com/cwensley/8348615c67618dc46102We can actually just check inApplySettings()if needed. Propagating it back into the UI is the hard part.