Skip to content

Conversation

@gonX
Copy link
Member

@gonX gonX commented Jan 21, 2025

This has no real change for releases, but helps with debugging without the bindingHandler in place since it counts as a filter.

Pre-PR, if you have the binding handler removed:

Plugins do not show up in the filter when using exactly 1 plugin

Post-PR, if you have the binding handler removed:

Plugins show up in log output regardless of filter count, unless no filters are enabled.


Mostly harmless code change, so targeting v0.6.5.1

This has no real change for releases, but helps with debugging without the bindingHandler in place since it counts as a filter
@gonX gonX added the enhancement New feature or request label Jan 21, 2025
@gonX gonX added this to the v0.6.5.1 milestone Jan 21, 2025
@gonX gonX changed the title Daemon: Refactor filter log output statement Daemon: Properly output filters to log in development edge case Jan 22, 2025
@gonX gonX changed the title Daemon: Properly output filters to log in development edge case [06x] Daemon: Properly output filters to log in development edge case Jan 22, 2025
Copy link
Member

@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Kuuuube Kuuuube merged commit 01b2e5c into OpenTabletDriver:0.6.x Jan 22, 2025
8 checks passed
@gonX gonX deleted the 06x-refactor-filter-log-output branch September 24, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants