[0.6.x] Fix NullReferenceException when settings with missing output mode area are loaded #3672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
One issue with this, only once you restart, the interface will be empty, Should i null or do something with the output otherwise? |
Contributor
Author
|
maybe this could do diff --git a/OpenTabletDriver.UX/Controls/Output/OutputModeEditor.cs b/OpenTabletDriver.UX/Controls/Output/OutputModeEditor.cs
index 3cf617db..847e328a 100644
--- a/OpenTabletDriver.UX/Controls/Output/OutputModeEditor.cs
+++ b/OpenTabletDriver.UX/Controls/Output/OutputModeEditor.cs
@@ -69,6 +69,7 @@ namespace OpenTabletDriver.UX.Controls.Output
{
ProfileChanged?.Invoke(this, new EventArgs());
UpdateTablet();
+ UpdateOutputMode(Profile?.OutputMode);
}
public BindableBinding<OutputModeEditor, Profile> ProfileBinding
@@ -89,6 +90,7 @@ namespace OpenTabletDriver.UX.Controls.Output
private AbsoluteModeEditor absoluteModeEditor = new AbsoluteModeEditor();
private RelativeModeEditor relativeModeEditor = new RelativeModeEditor();
private TypeDropDown<IOutputMode> outputModeSelector = new TypeDropDown<IOutputMode> { Width = 300 };
+ private Label outputModeUnsupported = new Label { Text = "No supported output mode selected.", TextAlignment = TextAlignment.Center, VerticalAlignment = VerticalAlignment.Center };
public void SetTabletSize(TabletReference tablet)
{
@@ -128,6 +130,8 @@ namespace OpenTabletDriver.UX.Controls.Output
editorContainer.Content = absoluteModeEditor;
else if (showRelative)
editorContainer.Content = relativeModeEditor;
+ else
+ editorContainer.Content = outputModeUnsupported;
}
}
} |
InfinityGhost
previously approved these changes
Jan 10, 2025
Member
Apply this and we can roll with that. |
Contributor
Author
|
Applied, will get some rest now before my sense force me to |
InfinityGhost
approved these changes
Jan 10, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3671
Also fixes the same issue with Profiles (They are just Settings files)
Needs testing.
Steps to reproduce :
Pathfor the active output mode