Skip to content

[06x] Automatic labeling for pull requests #3667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Kuuuube merged 7 commits into from
Sep 2, 2025
Merged

[06x] Automatic labeling for pull requests #3667

Kuuuube merged 7 commits into from
Sep 2, 2025

Conversation

@gonX
Copy link
Member

@gonX gonX commented Jan 8, 2025 •
edited
Loading

Fixes #3526 for 0.6.x

Still needs:

  • Path tests as described in the issue
  • rename .yamls to .yml (for consistency)

@gonX gonX added incomplete This is not finished ci Affects CI meta Dotfiles, scripts or Github files needs-forward-port PR or its features needs to be ported to development branch labels Jan 8, 2025
@gonX gonX changed the title Automatic labeling for pull requests [06x] Automatic labeling for pull requests Jan 8, 2025
@gonX gonX added tests Adds or modifies a unit test and removed incomplete This is not finished labels Jan 8, 2025
@gonX
Copy link
Member Author

gonX commented Jan 8, 2025

Should be ready now. Worth noting that it's not directly possible to test the functionality without merging first.

@gonX gonX marked this pull request as draft January 16, 2025 16:29
@gonX
Copy link
Member Author

gonX commented Jan 16, 2025 •
edited
Loading

I noticed this is throwing some errors on the branch I have locally due to some misconfigured stuff. Will get this sorted before this is undrafted.

/edit: fixed

@gonX
workflows/pr-labeler: Move reusable workflow to top level
e6dfda3 
This is necessary, otherwise GitHub throws the following error:

> invalid value workflow reference: workflows must be defined at the top
> level of the .github/workflows/ directory

This is discussed at https://github.com/orgs/community/discussions/10773
@gonX gonX marked this pull request as ready for review January 16, 2025 16:37
@gonX gonX added this to the v0.6.6 milestone Aug 27, 2025
Kuuuube
Kuuuube approved these changes Sep 2, 2025
View reviewed changes
Copy link
Member

@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Can be fixed later if it causes any issues.

@Kuuuube Kuuuube merged commit 3750be5 into OpenTabletDriver:0.6.x Sep 2, 2025
9 checks passed
@Kuuuube Kuuuube mentioned this pull request Sep 2, 2025
Merged
@gonX gonX deleted the 06x-pr-labeler branch September 9, 2025 11:07
@gonX gonX mentioned this pull request Sep 9, 2025
Open
@gonX gonX modified the milestones: v0.6.7, v0.6.6 Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kuuuube Kuuuube Kuuuube approved these changes

Assignees

No one assigned

Labels

ci Affects CI meta Dotfiles, scripts or Github files needs-forward-port PR or its features needs to be ported to development branch tests Adds or modifies a unit test

Projects

None yet

Milestone

v0.6.6

Development

Successfully merging this pull request may close these issues.

2 participants

@gonX @Kuuuube