[0.6.x] Fix another case of Output Mode NullException when saving using the tablet #3631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've identified the core issue : The output mode is being used while it's being initialized.
InputDeviceTreeshould not callRead()on the output mode until it's ready.This could be avoided by setting the OutputMode at a later time.
Now the real question is: How, has this not been caught in 5 minutes of testing.
The other question is related to plugins :
Some plugins fetch the output mode from the device itself, for diverse reasons.
Setting the output mode later would result in a failure to fetch such output mode (unless they check on every reports)