Skip to content

Conversation

@Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Dec 4, 2024

Fixes #3582 for 0.6.x, no use in adding this to master for now.

Should help when there are weird unprintable characters or some weirdness in the string.

@Kuuuube Kuuuube added enhancement New feature or request gui Affects driver GUI needs-forward-port PR or its features needs to be ported to development branch labels Dec 4, 2024
@Kuuuube Kuuuube changed the title Add device string as hex output for string reader Escape special characters and unicode from string reader output Dec 4, 2024
@Kuuuube Kuuuube added this to the v0.6.5 milestone Dec 4, 2024
@Kuuuube Kuuuube force-pushed the hex-string-request branch from e1e3bf1 to 9ee0054 Compare December 4, 2024 22:09
Copy link
Member

@gonX gonX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming it's similar to the bottom field of this result (as was posted in Discord):
image
image

@Kuuuube
Copy link
Member Author

Kuuuube commented Dec 4, 2024

Yep. The bottom result is with System.Text.Json.JsonEncodedText.Encode(s).ToString().

@gonX gonX merged commit 3d5e741 into OpenTabletDriver:0.6.x Dec 4, 2024
8 checks passed
@gonX gonX removed the needs-forward-port PR or its features needs to be ported to development branch label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request gui Affects driver GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

String reader non-dumps should better show non-characters e.g. alternate hex representation

2 participants