[0.6.x] Add options to disable pressure & tilt #3564
Conversation
|
What's the reasoning behind wanting this option? Considering #2894 mentions it not changing behavior. |
b1cc5f2 to
84d50b0
Compare
|
It doesn’t affect apps that don’t support pressure sensitivity. However, in apps that do, it’s not always possible to turn off pressure sensitivity to achieve a consistent stroke width. For example, I couldn’t find a way to do this in OneNote. I also remember seeing people who wanted to temporarily disable this feature. |
gonX
left a comment
There was a problem hiding this comment.
Generally LGTM, but not sure if the UI approach is correct here. Can you provide a screenshot of how this looks in the pen binding tab?
|
| /// <summary> | ||
| /// Whether to disable pressure | ||
| /// </summary> | ||
| public bool DisablePressure { set; get; } | ||
|
|
||
| /// <summary> | ||
| /// Whether to disable tilt | ||
| /// </summary> | ||
| public bool DisableTilt { set; get; } | ||
|
|
There was a problem hiding this comment.
Is this necessary now that it's also defined in IOutputMode? This class inherits from IOutputMode anyway.
|
I'm going to move this to the 0.6.6 milestone since changes are still requested. |
|
Needs testing on Linux, will do this at some point. There are merge conflicts, btw. |
gonX
left a comment
There was a problem hiding this comment.
Pressure/tilt status is logged even when using output modes that don't implement pressure/tilt (like Absolute Mode on Windows or Linux). I feel this can be confusing for users using a mode that doesn't support this. I've attached a patchfile that fixes this.
0001-daemon-Only-log-pressure-tilt-when-relevant.patch.gz
(github didn't like the naked patch file)
The patch checks for IPressureHandler/ITiltHandler before spewing log output - this was annoying to fix given the current typing, since Pointer only exists in AbsoluteOutputMode/RelativeOutputMode, not in OutputMode itself.
c72bd7b to
7fb096b
Compare
gonX
left a comment
There was a problem hiding this comment.
LGTM, but this has conflicts and I would like to merge it. Do you want me to handle this or would you like to fix it yourself?
All changes requested has been resolved (the requested properties was moved to IOutputMode)
Previously, we would emit pressure/tilt state regardless of whether the outputmode supported sending these, which could be confusing in some situations
7fb096b to
beec9b2
Compare
Kuuuube
left a comment
There was a problem hiding this comment.
Looks good. Works as advertised. On linux with artist mode since the tip binding is triggered solely by pressure this just kills tip input entirely, maybe there's a way artist mode can send a tip down without pressure. In other output modes the tip down does send like normal since it's solely OTD triggering it.
A separate option for disabling pressure and tilt might be better than duplicating them to create more combinations of modes.