Skip to content

[0.6.x] fix: double click in relative mode #3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gonX merged 1 commit into from
Nov 30, 2024
Merged

[0.6.x] fix: double click in relative mode #3559

gonX merged 1 commit into from
Nov 30, 2024

Conversation

@AkiSakurai
Copy link
Contributor

@AkiSakurai AkiSakurai commented Nov 25, 2024

QueuePendingPosition expects relative coordinates in relative mode, but was incorrectly pulling absolute system coordinates. Now using proper (0,0) deltas for clicks.

@AkiSakurai
fix: double click in relative mode
60f432b 
QueuePendingPosition expects relative coordinates in relative mode, but was incorrectly
pulling absolute system coordinates. Now using proper (0,0) deltas for clicks.
@AkiSakurai AkiSakurai changed the title fix: double click in relative mode [0.6.x] fix: double click in relative mode Nov 25, 2024
@jamesbt365 jamesbt365 added this to the v0.6.5 milestone Nov 25, 2024
@gonX gonX added bug Something isn't working macos Affects the MacOS platform desktop OpenTabletDriver.Desktop library, UX and Daemon use this as the core implementation. labels Nov 25, 2024
@InfinityGhost InfinityGhost added the needs-backport PR or its features needs to be backported to stable branch label Nov 26, 2024
@gonX gonX removed the needs-backport PR or its features needs to be backported to stable branch label Nov 30, 2024
gonX
gonX approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@gonX gonX left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll assume this is working, given you wrote most of the code. Otherwise we need to fix tests.

Nothing looks wrong with the code, so approving and merging.

/e: to note, the commit for master is 267e164 in #2894

@gonX gonX merged commit 35c363a into OpenTabletDriver:0.6.x Nov 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gonX gonX gonX approved these changes

@InfinityGhost InfinityGhost InfinityGhost approved these changes

Assignees

No one assigned

Labels

bug Something isn't working desktop OpenTabletDriver.Desktop library, UX and Daemon use this as the core implementation. macos Affects the MacOS platform

Projects

None yet

Milestone

v0.6.5

Development

Successfully merging this pull request may close these issues.

4 participants

@AkiSakurai @gonX @InfinityGhost @jamesbt365