[0.6.x] Backport Macos timer from #2342 #3549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I hate the linter. |
Contributor
Author
|
I'm getting lint error from stuff done in the original PR, send help. |
Contributor
Author
|
It's still complaining about import ordering, i'm gonna loose my mind |
Contributor
Author
|
Since the linter doesn't specify which import is causing an issue, i'm unable to fix it |
Kuuuube
reviewed
Nov 24, 2024
It's the exact same as 406225b again Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com>
Contributor
Author
|
Forgot to specify : But of course someone else is gonna need to add it manually and merging won't close it (happened to me a week ago) |
Member
|
Theres no point linking it, we will need to manually close it anyway because 0.6.x is not the default branch of the repository. |
gonX
reviewed
Nov 24, 2024
Contributor
|
Tested on intel mac, filter is working |
gonX
approved these changes
Nov 30, 2024
Member
gonX
left a comment
There was a problem hiding this comment.
Approving given AkiSakurai's testing
jamesbt365
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport timer changes from #2342 using the worst git usage skills known to man.