Reduce bloat of tablet configuration JSONs #3522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d835a5b to
c6d7205
Compare
jamesbt365
approved these changes
Nov 17, 2024
Kuuuube
approved these changes
Nov 17, 2024
gonX
approved these changes
Nov 17, 2024
Member
gonX
left a comment
There was a problem hiding this comment.
Code seems good, didn't check jsons too in depth tho, but what I saw also made sense to me.
Member
|
Out of curiosity, what happens if a user uses a config with the old specifications? Will it still load? |
Member
Author
|
It's only the tests that enforces that they be null, so whether the config defines nothing, null or is set to an empty array, they will still load. |
Member
|
Good enough for me, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.